[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix #1620 by ignoring captured state of re
Re: [Chicken-hackers] [PATCH] Fix #1620 by ignoring captured state of replaced variables
Thu, 4 Jul 2019 21:13:21 +0200
On Wed, Jul 03, 2019 at 02:05:21PM +0200, Peter Bex wrote:
> You're right, good catch! That was an oversight on my part, I only
> removed the captured check of the other variable. I hope this makes
> things faster in more cases. I can make and test a new patch, but don't
> know when I'll get around to it. Possibly in the weekend.
I tried this, but I got a crash when compiling CHICKEN with itself after
having built it with this patch.
I'm not even sure why it's doing this. The offending procedure was
append-map from mini-srfi-1, it's calling proc with the wrong number
I *think* the reason is that you can't replace variables which are
formal arguments to user procedures, because then all the calls will
have the wrong number of arguments.
Currently we don't seem to mark formal arguments in any special way,
so checking if they're captured seems to be the best way. So my initial
patch is fine, but perhaps we can refine it in some way by adding this
Description: PGP signature
Re: [Chicken-hackers] [PATCH] Fix #1620 by ignoring captured state of replaced variables, megane, 2019/07/11