[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix two "qualified symbol as keyword" mixu
From: |
felix . winkelmann |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix two "qualified symbol as keyword" mixups |
Date: |
Fri, 18 Jan 2019 20:28:48 +0100 |
> It turns out that here (and also in open-input-file*), keywords are
> supposed to be accepted to control the file mode. These are written
> as qualified symbols with no namespace (###text and ###append), which
> used to read the same as keywords. This is more of an accident than
> by design, as far as I can tell.
>
> Attached is a simple patch to fix this.
>
> I couldn't find any other places in core where we do something like this,
> so hopefully this fixes it.
Weird, indeed. I can't recall why this "###" syntax has been chosen,
keyword syntax is of course the right thing to do here. Perhaps this was
done during a transitional stage where "#:..." was not yet available...
felix