[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix two "qualified symbol as keyword" mixu
From: |
Mario Domenech Goulart |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix two "qualified symbol as keyword" mixups |
Date: |
Fri, 18 Jan 2019 19:34:34 +0100 |
Hi,
On Fri, 18 Jan 2019 19:07:29 +0100 Peter Bex <address@hidden> wrote:
> Mario found out that there's a weird bug in open-with-input-pipe:
> $ csi -e '(begin (import (chicken process)) (open-input-pipe "ls"))'
> Error: illegal input/output mode specifier: |###text|
>
> This breaks Salmonella, and probably many other programs which use
> pipes.
>
> It turns out that here (and also in open-input-file*), keywords are
> supposed to be accepted to control the file mode. These are written
> as qualified symbols with no namespace (###text and ###append), which
> used to read the same as keywords. This is more of an accident than
> by design, as far as I can tell.
>
> Attached is a simple patch to fix this.
>
> I couldn't find any other places in core where we do something like this,
> so hopefully this fixes it.
Thanks for the super fast fix, Peter. Pushed.
All the best.
Mario
--
http://parenteses.org/mario