[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Chicken-hackers] [PATCH] Fix complex (platform) clauses in .egg files
From: |
Peter Bex |
Subject: |
[Chicken-hackers] [PATCH] Fix complex (platform) clauses in .egg files |
Date: |
Sun, 12 Aug 2018 20:23:20 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
Hi all,
As I was trying to install spiffy on Haiku, I noticed that the
posix-groups egg (a dependency) refused to install because haiku
is not unix, and posix-groups.egg has a (platform unix) clause.
So I changed it to (platform (or unix haiku)) and it still failed.
If I swapped the two it would succeed. It turns out that the
check-platform procedure in chicken-install.scm was written with
the idea that fail was a continuation, or something. But it
isn't, so it would just raise an early error when it encountered
"unix" on the haiku platform, where that feature is not defined.
I also noticed that "and" will always fail, even if you do just
(platform (and unix)), which should be equivalent to (platform unix).
Attached is a relatively straightforward patch that simply allows
the loop to finish and return #t or #f, and if #f it will error.
Cheers,
Peter
0001-Fix-behaviour-of-complex-platform-clauses-in-.egg-fi.patch
Description: Text Data
signature.asc
Description: PGP signature
- [Chicken-hackers] [PATCH] Fix complex (platform) clauses in .egg files,
Peter Bex <=