[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix complex (platform) clauses in .egg fil
From: |
felix . winkelmann |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix complex (platform) clauses in .egg files |
Date: |
Sun, 12 Aug 2018 21:44:18 +0200 |
> Hi all,
>
> As I was trying to install spiffy on Haiku, I noticed that the
> posix-groups egg (a dependency) refused to install because haiku
> is not unix, and posix-groups.egg has a (platform unix) clause.
>
> So I changed it to (platform (or unix haiku)) and it still failed.
> If I swapped the two it would succeed. It turns out that the
> check-platform procedure in chicken-install.scm was written with
> the idea that fail was a continuation, or something. But it
> isn't, so it would just raise an early error when it encountered
> "unix" on the haiku platform, where that feature is not defined.
>
> I also noticed that "and" will always fail, even if you do just
> (platform (and unix)), which should be equivalent to (platform unix).
>
> Attached is a relatively straightforward patch that simply allows
> the loop to finish and return #t or #f, and if #f it will error.
>
Pushed.
felix