[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Drop "interrupots-enabled" declaration
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH] Drop "interrupots-enabled" declaration |
Date: |
Sat, 7 Apr 2018 21:44:02 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Mon, Apr 02, 2018 at 09:57:37PM +0200, address@hidden wrote:
> > On Fri, Mar 23, 2018 at 12:23:27PM +0100, address@hidden wrote:
> > > See attached patch.
> >
> > You're dropping (declare (not interrupts-enabled)) in the fft test.
> > Shouldn't that be replaced with (declare (disable-interrupts))?
>
> Yes, I thought about this, but the declarations are not quite correct,
> anyway. The code originated from a Gambit benchmark and used local
> declarations (which are globally applied in CHICKEN, regardless
> of lexical context). In the end it makes probably only a small performance
> difference
> (if any), and doesn't change the semantics of the test.
Ah ok, in that case it doesn't matter and it is arguably better without
the declarations.
Pushed, thanks!
Cheers,
Peter
signature.asc
Description: PGP signature