[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Drop "interrupots-enabled" declaration
|
From: |
felix . winkelmann |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Drop "interrupots-enabled" declaration |
|
Date: |
Mon, 02 Apr 2018 21:57:37 +0200 |
> On Fri, Mar 23, 2018 at 12:23:27PM +0100, address@hidden wrote:
> > See attached patch.
>
> You're dropping (declare (not interrupts-enabled)) in the fft test.
> Shouldn't that be replaced with (declare (disable-interrupts))?
Yes, I thought about this, but the declarations are not quite correct,
anyway. The code originated from a Gambit benchmark and used local
declarations (which are globally applied in CHICKEN, regardless
of lexical context). In the end it makes probably only a small performance
difference
(if any), and doesn't change the semantics of the test. If you insist, we
can add it, of course.
felix