[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Fix for #905

From: Felix
Subject: Re: [Chicken-hackers] [PATCH] Fix for #905
Date: Tue, 28 Aug 2012 21:21:39 +0200 (CEST)

From: Peter Bex <address@hidden>
Subject: [Chicken-hackers] [PATCH] Fix for #905
Date: Tue, 28 Aug 2012 21:04:37 +0200

> Hi all,
> As Ivan found out the hard way, I forgot to modify hash-table-copy
> when introducing the new randomization factor.  Funny enough, the
> tests did check whether the copied hash table has the same contents,
> but it doesn't reference any values in the hash table, which means
> the tests for copying passed with flying colours even though the
> hash table would effectively be unusable.
> I was a little tired yesterday, but meanwhile our tireless friend Mario
> found the bug and proposed a patch.  Here it is as a git changeset, with
> a small tweak to the regression tests to catch this situation.

Signed off and pushed. IIRC, this closes the last open tickets.  If
Ivan can confirm that nemo works with this patch, and salmonella
doesn't report any new errors for master, I'll update the manual
(#908) and we can tag a new release candidate.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]