[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] Fix for #905

From: Peter Bex
Subject: [Chicken-hackers] [PATCH] Fix for #905
Date: Tue, 28 Aug 2012 21:04:37 +0200
User-agent: Mutt/

Hi all,

As Ivan found out the hard way, I forgot to modify hash-table-copy
when introducing the new randomization factor.  Funny enough, the
tests did check whether the copied hash table has the same contents,
but it doesn't reference any values in the hash table, which means
the tests for copying passed with flying colours even though the
hash table would effectively be unusable.

I was a little tired yesterday, but meanwhile our tireless friend Mario
found the bug and proposed a patch.  Here it is as a git changeset, with
a small tweak to the regression tests to catch this situation.

"The process of preparing programs for a digital computer
 is especially attractive, not only because it can be economically
 and scientifically rewarding, but also because it can be an aesthetic
 experience much like composing poetry or music."
                                                        -- Donald Knuth

Attachment: 0001-For-copy-hash-table-after-making-a-new-hash-table-re.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]