[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-patch] Re: GNU patch: upcoming stable release; call for testing

From: Andreas Gruenbacher
Subject: [bug-patch] Re: GNU patch: upcoming stable release; call for testing
Date: Tue, 4 May 2010 18:50:56 +0200
User-agent: KMail/1.12.2 (Linux/; KDE/4.3.5; i686; ; )

On Tuesday 04 May 2010 18:51:14 Eric Blake wrote:
> On 05/04/2010 10:42 AM, Andreas Gruenbacher wrote:
> >> The testsuite also makes an unportable assumption; tests/read-only-files
> >> fails on cygwin when run as an administrator (basically, with root-like
> >> privileges where all files are readable regardless of mode).  You need
> >> to make that test skip if you detect superuser privileges.
> > 
> > Let's see if  test `id -u` = 0  will help.
> Won't work for cygwin (admin users are not necessarily uid 0), but 'test
> -r supposedly_unreadable' might.  When I get some more time, I'll help
> code something up.

Right, that is a better test.  I'll happily apply a patch.

> >> Also, as a nit, it's traditional to put the current copyright owner
> >> first, not last.  Emacs' copyright-mode only offers to list the current
> >> year in the first copyright line found; when I was preparing this patch,
> >> that meant that emacs kept trying to add the year 2010 to Larry Wall
> >> instead of FSF.
> > 
> > Okay, fine.
> Would you like a patch that swaps copyright order along these lines?

I already changed that.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]