[bug-patch] Re: GNU patch: upcoming stable release; call for testing

[Eric Blake]

On 05/04/2010 10:42 AM, Andreas Gruenbacher wrote:
>> The testsuite also makes an unportable assumption; tests/read-only-files
>> fails on cygwin when run as an administrator (basically, with root-like
>> privileges where all files are readable regardless of mode).  You need
>> to make that test skip if you detect superuser privileges.
> 
> Let's see if  test `id -u` = 0  will help.

Won't work for cygwin (admin users are not necessarily uid 0), but 'test
-r supposedly_unreadable' might.  When I get some more time, I'll help
code something up.

> 
>> Also, as a nit, it's traditional to put the current copyright owner
>> first, not last.  Emacs' copyright-mode only offers to list the current
>> year in the first copyright line found; when I was preparing this patch,
>> that meant that emacs kept trying to add the year 2010 to Larry Wall
>> instead of FSF.
> 
> Okay, fine.

Would you like a patch that swaps copyright order along these lines?

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature