[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-mes] mes lib: abtod

From: Danny Milosavljevic
Subject: Re: [bug-mes] mes lib: abtod
Date: Fri, 15 Mar 2019 12:22:02 +0100

Hi Janneke,

I fixed the abtod test on wip-arm.  The reason the test xfailed is because 
printf had a bug: it used va_arg in order to read a double out of the variable 
argument list, but va_arg can't read things with size != 4 Byte.  (Because of 
promotion, smaller types are promoted to 4 Byte anyway, so it's not so bad)

Furthermore, apparently the doubles are 8 Byte aligned on ARM.

For now, I've added va_arg8 in order to read variables with 8 Bytes of size.  
va_arg8 could and eventually should be reintegrated with va_arg, but that's 
going to make va_arg even more ugly than it is now ;)

Could you try removing the XFAIL and check whether the test now passes on x86 
and x86_64 (or is at least better than before) ?

Attachment: pgp0yr1YjI1mE.pgp
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]