[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state |
|
Date: |
Tue, 14 Feb 2023 20:51:09 +0100 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
Sergey Bugaev, le mar. 14 févr. 2023 22:48:18 +0300, a ecrit:
> On Tue, Feb 14, 2023 at 10:20 PM Samuel Thibault
> <samuel.thibault@gnu.org> wrote:
> > > > +#if defined(__x86_64__) && !defined(USER32)
> > > > + uint64_t efl;
> > >
> > > Should this not be 'rfl' (for 'rflags')?
> >
> > In both cases, that would make the gnumach code have to distinguish the
> > two names, in the debugger and various other places.
>
> Yes,
Sorry, I got back to this mail and confused my first and second reading,
then mistaking your sentence for the internal structure.
What I said is only concerning the internal structure.
For this efl flag, I don't have any idea why flavio let it as efl.
Samuel