[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state
|
From: |
Sergey Bugaev |
|
Subject: |
Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state |
|
Date: |
Tue, 14 Feb 2023 22:48:18 +0300 |
On Tue, Feb 14, 2023 at 10:20 PM Samuel Thibault
<samuel.thibault@gnu.org> wrote:
> > > +#if defined(__x86_64__) && !defined(USER32)
> > > + uint64_t efl;
> >
> > Should this not be 'rfl' (for 'rflags')?
>
> In both cases, that would make the gnumach code have to distinguish the
> two names, in the debugger and various other places.
Yes, but that is already the case for every other register that
existed as exxx on x86 and got extended to rxxx in amd64. This same
patch already replaces esi -> rsi, eip -> rip, eax -> rax etc. Why
single out eflags?
Sergey