[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#51869: [PATCH] Add emacs-vala-mode

From: Liliana Marie Prikler
Subject: bug#51869: [PATCH] Add emacs-vala-mode
Date: Mon, 15 Nov 2021 20:42:16 +0100
User-agent: Evolution 3.34.2

Hi Vivien,

Am Montag, den 15.11.2021, 14:05 +0000 schrieb Vivien Kraus:
> Dear guix,
> There’s a vala mode for emacs. It is not very useful
I'd beg to differ.  Not opening Vala files in fundamental-mode is very

> The project is not very well maintained
I've experienced the same.  I previously used the melpa importer, so as
to not pollute upstream with it, but given that a patch is needed, we
might as well add it properly.

> Since I don’t have a solution to fix this issue, I went away and
> reverted the multiline support. It builds and is useful enough for
> LSP to kick in, so I consider it fixed.
> What do you think? Do you have a better fix?
Given my superior knowledge of Emacs Lisp (just kidding), I'd guess the
order of declarations is wrong.  Pull the defcustom before the other
thing and it ought to work.

> +   (version "20201218.2109")
> +   (source
> +    (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +            (url "https://github.com/rrthomas/vala-mode.git";)
> +            (commit "d696a8177e94c81ea557ad364a3b3dcc3abbc50f")))
Use the (let ((revision ...) (commit ...)) (package ...)) convention,
adding a note that upstream has no tagged release.  Base version
appears to be "0.1"


reply via email to

[Prev in Thread] Current Thread [Next in Thread]