[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#51869: [PATCH] Add emacs-vala-mode

From: Vivien Kraus
Subject: bug#51869: [PATCH] Add emacs-vala-mode
Date: Tue, 16 Nov 2021 19:48:32 +0000
User-agent: mu4e 1.6.9; emacs 27.2

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Please avoid pulling home-page up, it's not meant to be used as
> git-reference url.

>> +               (emacs-substitute-sexps "vala-mode.el"
>> +                 (";; Support multiline strings" 'disabled.)
>> +                 ("(defcustom vala-multiline-strings nil"
>> +                  "This variable is ignored.")))))))
> This inserts mostly bogus into the file rather than killing the sexps
> as it should.  

The first substitution fully kills the whole sexp (and inserts a comment
that reads "Support for multiline strings disabled." if you don’t read
too closely ^^). It’s true that the second does not kill the defcustom
expansion, but since it’s part of the intended public API, I’m not so
sure we should remove it altogether. I think it’s clearer for the user
that way, because the two modifications are kind of documented in the

Also, it’s shorter.

Anyway, Here are the two versions, you decide.


Attachment: 0001-gnu-Add-emacs-vala-mode-substitute-sexps.patch
Description: With sexp substitution

Attachment: 0001-gnu-Add-emacs-vala-mode-batch-edit.patch
Description: With a batch edit program

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]