[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32750: [PATCH 2/2] dfa: optmization of alternation in NFA

From: Paul Eggert
Subject: bug#32750: [PATCH 2/2] dfa: optmization of alternation in NFA
Date: Tue, 18 Sep 2018 21:12:18 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Norihiro Tanaka wrote:
I thought of various things for the name of the function, but I could
not think of a good name.

Yes, that's a tough one. I eventually came up with maybe_disable_superset_dfa. Perhaps we can think of an ever better one.

I installed your patches into Gnulib, along with the attached relatively-minor fixups, and then propagated the result into grep by updating the Gnulib version that the grep master points to.

As you may notice, nowadays I prefer using signed types like ptrdiff_t to unsigned ones like size_t, as the signed types have a significant advantage in overflow checking with gcc -fsanitize=undefined. Perhaps at some point we should change the other instances of size_t in dfa.c, but one step at a time.

Thanks again for the performance improvement.

Attachment: 0001-dfa-reorder-enum-for-efficiency.patch
Description: Text Data

Attachment: 0002-dfa-prune-states-as-we-go.patch
Description: Text Data

Attachment: 0003-dfa-tweak-allocation-performance.patch
Description: Text Data

Attachment: 0004-dfa-use-more-informative-function-name.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]