[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 26/34] tests: skip tests that require MBS support

From: Paolo Bonzini
Subject: Re: [PATCH 26/34] tests: skip tests that require MBS support
Date: Thu, 15 Sep 2011 13:16:10 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/15/2011 12:28 PM, Jim Meyering wrote:
diff --git a/tests/init.cfg b/tests/init.cfg
index f6ead9c..42889e6 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -78,3 +78,10 @@ require_ru_RU_koi8_r()
      *) skip_test_ 'ru_RU.KOI8-R locale not found' ;;

either MB or MBCS

+  require_en_utf8_locale_
+  printf 'é' | LC_ALL=en_US.UTF-8 grep '[[:lower:]]' \
+    || skip_ this test requires MBS support

I think a better test is

  printf '\xc3' | LC_ALL=en_US.UTF-8 grep '[é]'

Otherwise you're relying on glibc providing a full definition of [[:lower:]].

However, this test is already in use in tests/char-class-multibyte as a testcase. So if you make the change you need to remove this bit from char-class-multibyte.

for LOC in en_US.UTF-8 $LOCALE_FR_UTF8; do
  printf '\xc3\n' | LC_ALL=$LOC grep '[é]' > $out
  test $? = 1 || fail=1

I would also do this change quite early, before touching the code.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]