[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 26/34] tests: skip tests that require MBS support

From: Paolo Bonzini
Subject: Re: [PATCH 26/34] tests: skip tests that require MBS support
Date: Thu, 15 Sep 2011 13:51:33 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/15/2011 01:41 PM, Jim Meyering wrote:
>  I think a better test is
>     printf '\xc3' | LC_ALL=en_US.UTF-8 grep '[é]'
>  Otherwise you're relying on glibc providing a full definition of [[:lower:]].

Good point.
However, I'll do that as a separate patch.

Please try doing that in this one.

>  However, this test is already in use in tests/char-class-multibyte as
>  a testcase.  So if you make the change you need to remove this bit
>  from char-class-multibyte.
>  for LOC in en_US.UTF-8 $LOCALE_FR_UTF8; do
>     out=out3-$LOC
>     printf '\xc3\n' | LC_ALL=$LOC grep '[é]'>  $out
>     test $? = 1 || fail=1
>  done
>  I would also do this change quite early, before touching the code.

I would have moved it, but it's not trivial due to the nearby
use of skip_test_, which is changed in another commit.

Just move *all* tests/ commits early. In fact, I suggest that you split this series in three/four pieces if possible. Splitting out tests/ parts and submitting them separately should be easy, and ensures that all the early patches in the series are tested right.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]