Re: [PATCH 2/9] grep: remove one #ifdef

[Jim Meyering]

Paolo Bonzini wrote:
> * search.c (Ecompile): Always go through GEAcompile.

This lazy^W time-constrained reviewer doesn't see off-hand why
you're doing this, or why it's ok.  I presume it's a no-semantic-change.
Can you add a few words of explanation to the log?

>  src/search.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/src/search.c b/src/search.c
> index c986d48..1d3868a 100644
> --- a/src/search.c
> +++ b/src/search.c
> @@ -257,16 +257,10 @@ is_mb_middle(const char **good, const char *buf, const 
> char *end)
>  #endif /* MBS_SUPPORT */
>
>  #if defined(GREP_PROGRAM) || defined(EGREP_PROGRAM)
> -#ifdef EGREP_PROGRAM
> -COMPILE_FCT(Ecompile)
> -{
> -  reg_syntax_t syntax_bits = RE_SYNTAX_POSIX_EGREP;
> -#else
>  /* No __VA_ARGS__ in C89.  So we have to do it this way.  */
>  static COMPILE_RET
>  GEAcompile (char const *pattern, size_t size, reg_syntax_t syntax_bits)
>  {
> -#endif /* EGREP_PROGRAM */
>    const char *err;
>    const char *p, *sep;
>    size_t total = size;
> @@ -365,12 +359,12 @@ COMPILE_FCT(Acompile)
>  {
>    return GEAcompile (pattern, size, RE_SYNTAX_AWK);
>  }
> +#endif /* !EGREP_PROGRAM */
>
>  COMPILE_FCT(Ecompile)
>  {
>    return GEAcompile (pattern, size, RE_SYNTAX_POSIX_EGREP);
>  }
> -#endif /* !EGREP_PROGRAM */
>
>  EXECUTE_FCT(EGexecute)
>  {