Re: [PATCH 5/9] grep: eliminate {COMPILE,EXECUTE}_{RET,ARGS,FCT}

[Jim Meyering]

Paolo Bonzini wrote:
> Modern compilers warn about type mismatches.
>
> * src/grep.c (do_execute): Write full declaration.
> * src/grep.h (COMPILE_RET, COMPILE_ARGS, COMPILE_FCT, EXECUTE_RET,
> EXECUTE_ARGS, EXECUTE_FCT): Remove.
> (compile_fp_t, execute_fp_t): Write full declaration.
> * src/search.c (GEAcompile, Gcompile, Acompile, Ecompile, EGexecute,
> Fcompile, Fexecute, Pcompile, Pexecute): Write full declaration.
...
Thank you for another welcome clean-up.
ACK, but please split lines longer than 80 columns.

> -static EXECUTE_RET do_execute EXECUTE_ARGS
> +static size_t
> +do_execute (char const *buf, size_t size, size_t *match_size, char const 
> *start_ptr)
...
> -EXECUTE_FCT(EGexecute)
> +static size_t
> +EGexecute (char const *buf, size_t size, size_t *match_size, char const 
> *start_ptr)
...
> -EXECUTE_FCT(Fexecute)
> +static size_t
> +Fexecute (char const *buf, size_t size, size_t *match_size, char const 
> *start_ptr)
...
> -EXECUTE_FCT(Pexecute)
> +static size_t
> +Pexecute (char const *buf, size_t size, size_t *match_size, char const 
> *start_ptr)