[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: non-empty matches following empty ones

From: Charles Levert
Subject: Re: Patch: non-empty matches following empty ones
Date: Fri, 26 Aug 2005 20:19:27 -0400
User-agent: Mutt/1.4.1i

* On Friday 2005-08-26 at 11:33:34 +0100, Julian Foad wrote:
> 1. With "--only-matching" or "--color", ensure non-empty matches are
>    displayed or colored even after an empty match.  (Bug fix.)

Given the single way that print_line_middle()
is called in the source code, it's implicit that
this is about --only-matching and --color, and
we know what it is these options do.  A patch to
this function can only be about that.  Already,
mentioning print_line_middle() covers this and
the ChangeLog entry is not there to redundantly
document the existing source code.  Taking this
into account before reading any further beyond
the first ":", the existing comment is IMO

> 2. With "--only-matching" or "--color", don't display or color empty
>    matches.  (Behaviour change.)

They were not displayed or colorized before,
so there is no change in behavior there.
This unchanged behavior may differ from expected
behavior, but that's an eye-of-the-beholder
issue and what's unchanged doesn't belong in a
_change_ log.

The ChangeLog entry does mention that these GNU
extensions were otherwise unspecified and that
was the real problem.  Who's to say what's a
bug or a feature before they are, then?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]