[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bootstrap: Provide a hook for submodule _SRCDIR setup

From: Bruno Haible
Subject: Re: [PATCH] bootstrap: Provide a hook for submodule _SRCDIR setup
Date: Sun, 27 Nov 2022 22:49:26 +0100

Arsen Arsenović wrote:
> --jitter-srcdir doesn't really even make
> sense in autopull?  My thinking is that autopull is pretty fixed on
> operate on submodules AFAIU (seemingly backed up by --jitter-srcdir
> previously being ignored for the pull stage anway), so just removing all
> of that logic and only leaving the defaulting logic in the post_import
> hook should work.

If you do this, you lose an interesting use-case: Imagine a developer
who makes changes to jitter (maybe Luca himself) and wants to test the
changes with different versions of poke (which reside in different

> Since the autogen case is no longer concerned with pulling at all, or
> $use_git, just letting it default to "jitter" should work for all cases
> (those that want to override it can anyway), as long as the option hook
> exports JITTER_SRCDIR in bootstrap.

Yes, I think so.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]