[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bootstrap: Provide a hook for submodule _SRCDIR setup

From: Arsen Arsenović
Subject: Re: [PATCH] bootstrap: Provide a hook for submodule _SRCDIR setup
Date: Sun, 27 Nov 2022 22:06:26 +0100


Bruno Haible <bruno@clisp.org> writes:

>> * build-aux/bootstrap: Regenerate.
> Thanks; I pushed that part in your name.


> Yes, all 4 of bootstrap_option_hook, bootstrap_print_option_usage_hook,
> bootstrap_post_pull_hook, bootstrap_post_import_hook then deal with
> JITTER_SRCDIR in one form or the other.
> If it works with this reorganization of the code, I would prefer not to add
> a bootstrap_srcdirs_hook.

Hmm, now that I think about it, --jitter-srcdir doesn't really even make
sense in autopull?  My thinking is that autopull is pretty fixed on
operate on submodules AFAIU (seemingly backed up by --jitter-srcdir
previously being ignored for the pull stage anway), so just removing all
of that logic and only leaving the defaulting logic in the post_import
hook should work.

Since the autogen case is no longer concerned with pulling at all, or
$use_git, just letting it default to "jitter" should work for all cases
(those that want to override it can anyway), as long as the option hook
exports JITTER_SRCDIR in bootstrap.

In that case, I'll just update to today's revision of gnulib and see
about upstreaming that in poke.

Thanks, and sorry about the fuss ;)

Have a great night.
Arsen Arsenović

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]