|
From: | Giulio Benetti |
Subject: | Re: [PATCH] lib/gettext.h: fix warning if gettext is already present |
Date: | Sun, 26 Jan 2020 23:47:48 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Hi Bruno, On 1/26/20 11:12 PM, Bruno Haible wrote:
Hi Giulio,Building on an environment where gettext is already present leads to emitting a warning about gettext_noop() alread defined.Where is the first definition of gettext_noop located? In another copy of gettext.h? In a third-party .h file? Or in the .c file that is being compiled?
In a entire gettext. In my specific case I'm adding package libbytesize [1], where they add src/gettext.h but they define ENABLE_NLS in any case [2]. Maybe configure.ac should define it or not according to gettext presence... What do you think?
Here I've opened a pull request: https://github.com/storaged-project/libbytesize/pull/64 The goal is to add libbytesize to Buildroot. [1]: https://github.com/storaged-project/libbytesize[2]: https://github.com/storaged-project/libbytesize/blob/master/configure.ac#L21
-- Giulio Benetti Benetti Engineering sas
Bruno
[Prev in Thread] | Current Thread | [Next in Thread] |