Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

[Giulio Benetti]

On 1/26/20 11:47 PM, Giulio Benetti wrote:
> Hi Bruno,
>
> On 1/26/20 11:12 PM, Bruno Haible wrote:
> > Hi Giulio,
> >
> > > Building on an environment where gettext is already present leads to
> > > emitting a warning about gettext_noop() alread defined.
> >
> > Where is the first definition of gettext_noop located? In another copy
> > of gettext.h? In a third-party .h file? Or in the .c file that is being
> > compiled?
>
> In a entire gettext. In my specific case I'm adding package libbytesize

Here ^^^^^^^^^^^^^^^^ I meant:
In a environment where gettext is already installed.

> [1], where they add src/gettext.h but they define ENABLE_NLS in any case
> [2]. Maybe configure.ac should define it or not according to gettext
> presence... What do you think?
>
> Here I've opened a pull request:
> https://github.com/storaged-project/libbytesize/pull/64
>
> The goal is to add libbytesize to Buildroot.
>
> [1]: https://github.com/storaged-project/libbytesize
> [2]:
> https://github.com/storaged-project/libbytesize/blob/master/configure.ac#L21

--
Giulio Benetti
Benetti Engineering sas