|
From: | Paolo Bonzini |
Subject: | Re: Buildreport for GnuTLS 2.8.3 |
Date: | Mon, 17 Aug 2009 17:47:43 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 |
+int +siginterrupt (int sig, int flag) +{ + struct sigaction act; + + if (sigaction (sig, NULL,&act)< 0) + return -1; POSIX ignores sigaction failure here, rather than returning -1.
In practice the only difference is that for EINVAL the POSIX version will cause spurious valgrind failures. Better to keep the if, even though I agree that it's better not to use siginterrupt in the first place.
If the code is the one of http://www.google.com/codesearch/p#PvVS7tbiN-U/gnutls-1.6.0/src/tests.c it seems easier indeed to just use sigaction without SA_RESTART. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |