Re: Buildreport for GnuTLS 2.8.3

[Eric Blake]

> > It fails to build on IRIX 5.3 due to missing siginterrupt function:
> > ld: ERROR 33: Unresolved text symbol "siginterrupt" -- 1st referenced by
> > tests.o.
> >
> > Since gnulib does not provide a siginterrupt replacement I instead added
> > the replacement used by bash 4.0 to tests.c:
> 
> Thanks for the report, I believe this should be fixed in gnulib.

I'm not so sure.  POSIX lists siginterrupt as obsolete (in other
words, the better action would be fixing your code to comply
to modern POSIX, rather than making it easy to rely on a
crutch for using an obsolete interface, similar to how we
recommend memset over bzero).

> I propose to add this new module.  Objections?  I'll push it shortly
> otherwise.

If others agree that adding this crutch is worthwhile, though,
then I would suggest using the example straight out of POSIX:
http://www.opengroup.org/onlinepubs/9699919799/functions/siginterrupt.html

+int
+siginterrupt (int sig, int flag)
+{
+  struct sigaction act;
+
+  if (sigaction (sig, NULL, &act) < 0)
+    return -1;

POSIX ignores sigaction failure here, rather than returning -1.

Everything else with your patch looked okay to me.

-- 
Eric Blake

-- 
View this message in context: 
http://www.nabble.com/Re%3A-Buildreport-for-GnuTLS-2.8.3-tp25008027p25008955.html
Sent from the Gnulib mailing list archive at Nabble.com.