[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59691: Html-like constructs fail in typescript
From: |
Jostein Kjønigsen |
Subject: |
bug#59691: Html-like constructs fail in typescript |
Date: |
Tue, 29 Nov 2022 22:37:25 +0100 |
Nice!
Should we until further notice assume that js-ts-mode suffers from the same
issues, and that a jsx-ts-mode might be needed too? To me it at least sounds
plausible.
Speaking of duplication… Now that we have tree-sitter wouldn’t it be possible
to use the same parser and/or the same major-modes for JS/JSX as we already do
for TS/TSX? JS/JSX is just Typescript without the type-annotations, right?
Or are there good reasons for having separate modes for these?
—
Jostein Kjønigsen
https://jostein.kjønigsen.net
> On 29 Nov 2022, at 22:04, Theodor Thornhill <theo@thornhill.no> wrote:
>
>
> Hi Jostein!
>
> I already have a fix for this bug lined up, and will send the fix as
> soon as I get my other stuff applied. It relies on another patch that
> is waiting.
>
> The solution is to create two modes: typescript-ts-mode and
> tsx-ts-mode. They have separate parsers, and should be treated as
> separate languages. That means that in a .ts file we enable the
> 'typescript' language, and in .tsx we enable the 'tsx' language. This
> exact issue is why they have two languages.
>
> In other words, we cannot support this in typescript-ts-mode.
>
> I hope to get this in pretty soon :)
>
> Theo
bug#59691: Html-like constructs fail in typescript, Eli Zaretskii, 2022/11/30
bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Yuan Fu, 2022/11/30