[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#57082: 29.0.50; emacs-news-view-mode breakage
From: |
Stephen Berman |
Subject: |
bug#57082: 29.0.50; emacs-news-view-mode breakage |
Date: |
Wed, 10 Aug 2022 10:19:19 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
On Wed, 10 Aug 2022 10:36:22 +0300 Juri Linkov <juri@linkov.net> wrote:
>>> Also don't understand why is this change:
>>>
>>> (when outline-minor-mode-highlight
>>> - (if (and global-font-lock-mode (font-lock-specified-p
>>> major-mode))
>>> - (progn
>>> - (font-lock-add-keywords nil outline-font-lock-keywords t)
>>> - (font-lock-flush))
>>> - (outline-minor-mode-highlight-buffer)))
>>> + (when (and global-font-lock-mode (font-lock-specified-p
>>> major-mode))
>>> + (font-lock-add-keywords nil outline-font-lock-keywords t)
>>> + (font-lock-flush))
>>> + (outline-minor-mode-highlight-buffer))
>>>
>>> `outline-minor-mode-highlight-buffer' is intended only for buffers
>>> that don't support font-lock highlighting.
>>
>> Yes, but with that change, arrows are displayed on first visiting the
>> NEWS buffer; without it, they only appear when typing TAB on an outline
>> heading.
>
> This change broke fontification e.g. in diff buffers that now
> add outline faces on diff hunks. So we need another solution.
Oh, dear (as I noted in my OP, I only checked NEWS and *Help* with
describe-binding). But do you have a recipe to see this? When I create
a diff with vc-diff I don't see outline faces on the hunks.
Steve Berman
- bug#57082: 29.0.50; emacs-news-view-mode breakage, (continued)
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Juri Linkov, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Gregory Heytings, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Juri Linkov, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Gregory Heytings, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Drew Adams, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Juri Linkov, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage,
Stephen Berman <=
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Juri Linkov, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Stephen Berman, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Juri Linkov, 2022/08/11