[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#57082: 29.0.50; emacs-news-view-mode breakage
From: |
Juri Linkov |
Subject: |
bug#57082: 29.0.50; emacs-news-view-mode breakage |
Date: |
Wed, 10 Aug 2022 11:07:14 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> I think that's wrong, yes. Every GUI I'm familiar with does it the other way:
>>
>> > Closed Item
>> v Open Item
>> > Closed Sub Item
>>
>> This is the visual style used in GNOME (at least, the theme I'm using), MS
>> Windows, macOS, Firefox/Thunderbird, and probably others. More importantly,
>> it's also the style Emacs already uses elsewhere: see the Customize UI.
>
> Ah, of course, I didn't even think to look there (oops again).
>
> diff --git a/lisp/outline.el b/lisp/outline.el
> index 7750f9a75d..8132043097 100644
> --- a/lisp/outline.el
> +++ b/lisp/outline.el
> @@ -294,16 +294,16 @@ outline-minor-mode-use-buttons
> :version "29.1")
>
> (define-icon outline-open button
> - '((emoji "▶️")
> - (symbol " ⯈ ")
> + '((emoji "🔽")
> + (symbol " ⯆ ")
> (text " open "))
> "Icon used for buttons for opening a section in outline buffers."
> :version "29.1"
> :help-echo "Open this section")
It seems the problem is somewhere else - in code that uses these definitions,
because here semantically everything is correct: the outline-open button
for opening a section means that the current state of the button is closed.
This assumes that in "outline-open" the word "open" is a verb.
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Stephen Berman, 2022/08/09
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Lars Ingebrigtsen, 2022/08/09
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Juri Linkov, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Gregory Heytings, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Juri Linkov, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Gregory Heytings, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Drew Adams, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Lars Ingebrigtsen, 2022/08/12
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Juri Linkov, 2022/08/10
- bug#57082: 29.0.50; emacs-news-view-mode breakage, Stephen Berman, 2022/08/10