bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark

[Jim Porter]

On 8/3/2022 11:53 PM, Eli Zaretskii wrote:
> > Cc: 56896@debbugs.gnu.org
> > From: Jim Porter <jporterbugs@gmail.com>
> > Date: Wed, 3 Aug 2022 20:24:24 -0700
> >
> > Finally, I adjusted the names of a couple bookmark variables and let
> > users specify a bitmap (or nil) for 'bookmark-fringe-mark'. Note that
> > changing this (via Customize or not) doesn't force an update of
> > already-set bookmark fringe marks. That would be nice to have, but I'd
> > need to study the code quite a bit more to figure out how to do this.
>
> I think we should fix this aspect, yes.  So please do try to find the
> way of doing it with some kind of :set function.

Ok, I figured out a way to do this. I added a proxy object 
('bookmark--fringe-mark') that I can dynamically set the 'fringe' 
property on, and then the :set function will update that and the display 
code will Just Work. Well, so long as a redisplay is triggered, but I 
think happens when you set options via Customize? It worked in my tests, 
anyway.

This method feels kind of hacky, but I can't think of a better way, and 
it's certainly more feasible than trying to find all the fringe markers 
manually. (Given that code can define custom bookmark handler functions, 
I'm not even sure that would have been possible...)

> If there's a detailed enough description in the manual(s), the NEWS
> entry can be quite short, just mentioning the new capabilities and
> variables.  If you don't think this is manual-worthy, the NEWS entry
> should be a bit more detailed.  But don't worry about that, we will
> get to it when you submit the actual text for NEWS.

I added some documentation and a NEWS entry for the user-facing part of 
this (the new option). There might be room to add more documentation though.

0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patch
Description: Text document