bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark

[Jim Porter]

On 8/2/2022 7:28 PM, Eli Zaretskii wrote:
> > Cc: 56896@debbugs.gnu.org
> > From: Jim Porter <jporterbugs@gmail.com>
> > Date: Tue, 2 Aug 2022 13:05:40 -0700
> >
> > 2) Let `bookmark-set-fringe-mark' take a symbol for a bitmap to use for
> > the mark (it currently takes a boolean). This would solve this immediate
> > case, but not other similar cases. For example, what if a user wants to
> > customize the fringe icons in diff-mode?
> What I had in mind was 2).
>
> Not sure if we need a general capability as in 3), but if it can be
> implemented cleanly and will be convenient for user options, I don't
> see why not.

How does this look? I added a new built-in fringe bitmap 
('large-circle'), since it should be generally-useful. There are a 
couple different fringe bitmaps for breakpoints that could use this, but 
I didn't do anything about that in this patch.

I also added a Customize widget to let users pick a fringe bitmap. I'm 
not super-familiar with Customize, so I just guessed on how this is 
supposed to be defined (I based it on the 'font' widget).

Finally, I adjusted the names of a couple bookmark variables and let 
users specify a bitmap (or nil) for 'bookmark-fringe-mark'. Note that 
changing this (via Customize or not) doesn't force an update of 
already-set bookmark fringe marks. That would be nice to have, but I'd 
need to study the code quite a bit more to figure out how to do this.

If this seems about right, I'll add a NEWS entry describing the change 
(though I welcome any feedback about how much should go in NEWS; I'm not 
100% sure).

0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patch
Description: Text document