bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#55696: 28.1; eshell fails to respect text-scale-increase


From: Jim Porter
Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase
Date: Fri, 10 Jun 2022 08:44:22 -0700

On 6/9/2022 10:52 PM, Eli Zaretskii wrote:
What if there's an external command named 'listify' -- is there any
chance that the test will invoke it?  If so, I think we should come up
with a safer solution.

No, that shouldn't be a problem. When Eshell executes something that looks like a shell command[1], the order of precedence is this:

1. If an alias for the command exists in .emacs.d/eshell/aliases, use that. (This won't happen in tests, since `eshell-test-command-result' binds `eshell-directory-name' to a temp dir.)

2. If there's a Lisp function named `eshell/COMMAND', use that.

3. If there's an external command named `COMMAND', use that.

4. If there's a Lisp function named `COMMAND', use that.

Otherwise, feel free to install the change, and thanks.

Thanks. (I don't have direct commit access, so hopefully you or someone else with commit access can install it when you/they get the chance.)

[1] Something like 'COMMAND args' or 'echo ${COMMAND args}'.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]