bug#55696: 28.1; eshell fails to respect text-scale-increase

[Eli Zaretskii]

> Cc: rudalics@gmx.at, 55696@debbugs.gnu.org, jeff.kowalski@gmail.com
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Sun, 5 Jun 2022 12:59:22 -0700
> 
> >> +      if (Vface_remapping_alist)
> > 
> > This should be
> > 
> >           if (!NILP (Vface_remapping_alist))
> 
> Thanks, fixed.

A couple more nits:

> +static enum body_unit
> +window_body_unit_from_symbol (Lisp_Object unit)
> +{
> +  return
> +    (unit == intern ("remap") ? BODY_IN_REMAPPED_CHARS
> +     : NILP (unit) ? BODY_IN_CANONICAL_CHARS
> +     : BODY_IN_PIXELS);
> +}

We already have the Qremap symbol in our sources, so you could use
that instead of calling 'intern' at run time.

> +The optional argument PIXELWISE defines the units to use for the
> +width.  If nil, return the largest integer smaller than WINDOW's pixel
> +width in units of the character width of WINDOW's frame.  If PIXELWISE
> +is `remap' and the default face is remapped (see
> +`face-remapping-alist'), use the remapped face to determine the
> +character width.  For any other value, return the width in pixels.
                     ^^^^^^^^^^^^^^^^^^^
"For any other non-nil value...", like in the manual.

> +The optional argument PIXELWISE defines the units to use for the
> +height.  If nil, return the largest integer smaller than WINDOW's
> +pixel height in units of the character height of WINDOW's frame.  If
> +PIXELWISE is `remap' and the default face is remapped (see
> +`face-remapping-alist'), use the remapped face to determine the
> +character height.  For any other value, return the height in
> +pixels.  */)

Same here.

I have no further comments; let's wait for Martin to chime in.

Thanks.