bug#47012: xref copies keymap properties to minibuffer

[Dmitry Gutov]

On 02.04.2021 09:08, Eli Zaretskii wrote:

> > Did you like any of the options I suggested?
>
> I didn't try them, and re-reading the thread now I don't think I
> understand which options are you referring to here.  There was one
> suggestion, to add the bold attribute to the existing face, which you
> later retracted because that face is already bold, but I see no other
> concrete suggestions for changes in that face.  What am I missing?
> Could you please list those options for which you'd like my opinion?

See bug#47574 for a self-contained explanation.

> > > In general, when discussing faces used by some feature (in this case
> > > Xref and project.el), please don't change the defaults of unrelated
> > > faces, let alone more general ones.
> >
> > I agree it should be a separate change/discussion.
> >
> > Should we continue that in a new bug report or on emacs-devel?
>
> If it's an important issue, probably the latter.

Important enough for me to file a bug, but not to spend much time 
fighting over it.

> If it's just a tool
> to fix some other face, I'd prefer not to change Occur faces at all,
> and instead find an independent way of doing TRT with Xref and/or
> project.el faces.
Yes, of course. I'm suggesting to change the 'match' face definition 
because I think all its uses will benefit from it (including Occur and 
Grep which I made sure to try with all proposed colors).

'xref-match' face is customizable separately, but I don't think it will 
be productive to change only it but not 'match'.

The faces are used similarly enough, so it's hard to justify making them 
look different in the default configuration.