bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#47012: xref copies keymap properties to minibuffer


From: Eli Zaretskii
Subject: bug#47012: xref copies keymap properties to minibuffer
Date: Fri, 02 Apr 2021 09:08:40 +0300

> Cc: 47012@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 2 Apr 2021 00:28:25 +0300
> 
> On 01.04.2021 22:06, Eli Zaretskii wrote:
> > Please don't make this change, it makes the matches very hard to find.
> > Personally, I don't understand how you can use such a background
> > color, unless you also customize the default background.
> 
> Did you like any of the options I suggested?

I didn't try them, and re-reading the thread now I don't think I
understand which options are you referring to here.  There was one
suggestion, to add the bold attribute to the existing face, which you
later retracted because that face is already bold, but I see no other
concrete suggestions for changes in that face.  What am I missing?
Could you please list those options for which you'd like my opinion?

> > In general, when discussing faces used by some feature (in this case
> > Xref and project.el), please don't change the defaults of unrelated
> > faces, let alone more general ones.
> 
> I agree it should be a separate change/discussion.
> 
> Should we continue that in a new bug report or on emacs-devel?

If it's an important issue, probably the latter.  If it's just a tool
to fix some other face, I'd prefer not to change Occur faces at all,
and instead find an independent way of doing TRT with Xref and/or
project.el faces.  There's nothing wrong with the default Occur faces,
and I saw no complaints about it.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]