bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#45562: [PATCH] Fix "comparison always the same" warnings found by lg


From: Eli Zaretskii
Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm
Date: Fri, 01 Jan 2021 14:05:09 +0200

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Stefan Kangas <stefan@marxist.se>,  45562@debbugs.gnu.org
> Date: Fri, 01 Jan 2021 12:08:46 +0100
> 
> >> --- a/src/alloc.c
> >> +++ b/src/alloc.c
> >> @@ -4001,7 +4001,7 @@ memory_full (size_t nbytes)
> >>      {
> >>        if (i == 0)
> >>          free (spare_memory[i]);
> >> -      else if (i >= 1 && i <= 4)
> >> +      else if (i <= 4)
> >>          lisp_align_free (spare_memory[i]);
> >>        else
> >>          lisp_free (spare_memory[i]);
> >
> > This is an optimization better left to the compiler, IMO.
> 
> I think the change made the code slightly clearer, though?  You don't
> have to think about whether there's anything in the range between 0 and
> >= 1.

If you like the modified code better, I won't object.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]