[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region
From: |
Lars Ingebrigtsen |
Subject: |
bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal |
Date: |
Sat, 12 Dec 2020 12:39:16 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> Rubocop can report warning when 'end' is at wrong column. It just
> reports the beginning column, of course.
>
> In ruby-mode, (thing-at-point 'sexp) signals an error at this position.
> I'm not sure exactly whether it's a problem in ruby-mode.
>
> But Flycheck uses (thing-at-poing 'symbol) for the same purpose, and the
> whole 'end' token gets highlighted (which is probably what we expect).
>
> In contrast, Flymake only highlights its first character ('e').
I had a look at the current `flymake-diag-region', and it does not use
(thing-at-point 'sexp) at present. It does use (end-of-thing 'sexp),
though.
So is this problem still present? There was no recipe for reproduction,
so it's not immediately clear.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal,
Lars Ingebrigtsen <=
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, Dmitry Gutov, 2020/12/12
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, Lars Ingebrigtsen, 2020/12/13
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, João Távora, 2020/12/13
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, Dmitry Gutov, 2020/12/13
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, João Távora, 2020/12/14
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, Dmitry Gutov, 2020/12/15
- Message not available
- Message not available
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, Glenn Morris, 2020/12/17
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, Dmitry Gutov, 2020/12/17
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, João Távora, 2020/12/18
- bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal, Dmitry Gutov, 2020/12/18