bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region


From: Dmitry Gutov
Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal
Date: Fri, 18 Dec 2020 17:22:18 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 18.12.2020 13:42, João Távora wrote:

I think this is rather a thingatpt.el issue, which makes no mention of
match-data destruction.  Regardless, it's decent enough to do that in
flymake-diag-region so I pushed save-match-data a bit higher.

By default we assume that any function can destroy match-data (and only a certain set doesn't).

But it's an easy mistake to make, especially given the fairly opaque implementation of (end-of-thing 'symbol).





reply via email to

[Prev in Thread] Current Thread [Next in Thread]