bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27341: updated patch to fix docstring


From: Alex Branham
Subject: bug#27341: updated patch to fix docstring
Date: Sun, 02 Jul 2017 21:25:56 +0200
User-agent: mu4e 0.9.18; emacs 25.2.1

On Sun 02 Jul 2017 at 19:13, address@hidden wrote:

> Alex Branham <address@hidden> writes:
>
>>> You missed the double spacing before the "Else,".
>>
>> D'oh! Fixed this time, sorry!
>
> Oh, the funny indentation came back, do you have some Emacs setting
> that's doing that?

Ugh. Fixed. I think it has to do with how I'm copy/pasting from my own init 
file.

>> Ok, now I don't use "r" and just get the region directly. I think that'll do 
>> the trick?
>
> Oh yeah, that works.  We should try not to add compiler warnings though:
>
>   ELC      net/eww.elc
>
> In toplevel form:
> ../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument
>     ‘end’
> ../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument
>     ‘beg’
>
> I think we can just drop the arguments as well, lisp programs can always
> do (eww (buffer-substring BEG END)) instead.

Dropped.

> Do you think the prompt string should be a bit more detailed?  "Query"
> seems a bit vague (e.g., consider if you hit M-s M-w by accident).
> Maybe we should just do (call-interactively 'eww) and then we'll get the
> prompt from there.

Yes, that's much better. Done, thanks.

Attachment: 0007-Make-eww-search-words-prompt-for-query-if-nothing-se.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]