[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27341: updated patch to fix docstring

From: npostavs
Subject: bug#27341: updated patch to fix docstring
Date: Sun, 02 Jul 2017 15:13:29 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux)

Alex Branham <address@hidden> writes:

>> You missed the double spacing before the "Else,".
> D'oh! Fixed this time, sorry!

Oh, the funny indentation came back, do you have some Emacs setting
that's doing that?

>>> Actually, we need to check (use-region-p) anyway in case the mark
>>> hasn't been activated yet in the buffer:
>> Hmm, I just tried this and it doesn't quite do the job.  I believe the
>> problem is that the (interactive "r") form throws an error when the mark
>> hasn't been activated yet.  To handle this case correctly you need to
>> replace the "r" with some lisp code that produces the argument list.
> Ok, now I don't use "r" and just get the region directly. I think that'll do 
> the trick?

Oh yeah, that works.  We should try not to add compiler warnings though:

  ELC      net/eww.elc

In toplevel form:
../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument
../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument

I think we can just drop the arguments as well, lisp programs can always
do (eww (buffer-substring BEG END)) instead.

Do you think the prompt string should be a bit more detailed?  "Query"
seems a bit vague (e.g., consider if you hit M-s M-w by accident).
Maybe we should just do (call-interactively 'eww) and then we'll get the
prompt from there.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]