bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS


From: Eli Zaretskii
Subject: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries
Date: Tue, 20 Dec 2016 17:37:58 +0200

> From: Reuben Thomas <address@hidden>
> Date: Mon, 19 Dec 2016 21:17:17 +0000
> Cc: address@hidden
> 
>     You are assuming that [[:alpha:]] and [A-Za-z] are identical.
> 
> ​No, because my patch does not change the current behaviour of the code. The 
> assumption that [:alpha:] is OK to use here instead of A-Za-z is already in 
> the code.​

Can you point out where in the code you see that assumption?

> ​From the conversation on other bugs, I think that the correct thing to do 
> here is to remove the first part of my patch (so that the hardwired 
> dictionaries keep their individual casechars and not-casechars settings), and 
> keep the second part of the patch (so that ispell-set-spellchecker-params 
> does not change them all to [:alpha:].
> 
> Does that sound plausible?

I think so, but we should make sure the hard-wired values work with
Aspell, before we make that change.  If they don't, we should provide
something that works for Aspell.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]