[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS

From: Reuben Thomas
Subject: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries
Date: Wed, 21 Dec 2016 17:31:46 +0000

On 21 December 2016 at 17:15, Eli Zaretskii <address@hidden> wrote:
> From: Reuben Thomas <address@hidden>
> Date: Wed, 21 Dec 2016 00:20:27 +0000
> Cc: address@hidden
> Here's an updated patch, which simply removes the overriding of the built-in
> CASECHARS/NOT-CASECHARS settings for ispell dictionaries. It assumes that all other dictionaries (either
> configured by the user or found by the various auto-scanning functions) will have sensible
> CASECHARS/NOT-CASECHARS values, which is expected to be the case at present.

Looks like you sent the wrong patch, as this:

> diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
> index 23ee412..82e5c2b 100644
> --- a/lisp/textmodes/ispell.el
> +++ b/lisp/textmodes/ispell.el
> @@ -436,114 +436,70 @@ ispell-dictionary-base-alist
>       ;; The default dictionary.  It may be English.aff, or any other
>       ;; dictionary depending on locale and such things.  We should probably
>       ;; ask ispell what dictionary it's using, but until we do that, let's
> -     ;; just use a minimal regexp. [:alpha:] will later be set if possible.
> -     "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1)
> +     ;; just use a minimal regexp.
> +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1)
>      ("american"                              ; Yankee English
> -     "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1)
> +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1)
>      ("brasileiro"                    ; Brazilian mode
> -     "[A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]"
> -     "[^A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]"
> -     "[']" nil nil nil iso-8859-1)
> +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil nil nil iso-8859-1)

leaves the overriding in place.  Am I missing something?

​I'm baffled, I somehow inverted the sense of what I meant to do, discarding the correct bit of the patch and keeping the incorrect bit. Sorry about that. I attach what should now be the correct patch.


Attachment: 0001-Keep-default-CASECHARS-NOT-CASECHARS-for-ispell-buil.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]