bug#12774: RE: bug#12774: 24.2.50; EMACS 24.2.50.1 crashing

[Eli Zaretskii]

> From: Vincent Belaïche <vincent.b.1@hotmail.fr> 
> Cc: 12774@debbugs.gnu.org
> Date: Sun, 04 Nov 2012 09:52:02 +0100
> 
> Debugger entered--Lisp error: (void-function org-mode-p)
>   (org-mode-p)
>   (if (org-mode-p) (setq bl nil))
>   (while bl (set-buffer (car (prog1 bl (setq bl (cdr bl))))) (if (org-mode-p) 
> (setq bl nil)))
>   (save-excursion (while bl (set-buffer (car (prog1 bl (setq bl (cdr bl))))) 
> (if (org-mode-p) (setq bl nil))) (if (org-mode-p) (progn (easy-menu-change 
> (quote ("Org")) "File List for Agenda" (append (list ["Edit File List" 
> (org-edit-agenda-file-list) t] ["Add/Move Current File to Front of List" 
> org-agenda-file-to-front t] ["Remove Current File from List" org-remove-file 
> t] ["Cycle through agenda files" org-cycle-agenda-files t] ["Occur in all 
> agenda files" org-occur-in-agenda-files t] "--") (mapcar (quote 
> org-file-menu-entry) (org-agenda-files t)))))))
>   (let ((bl (buffer-list))) (save-excursion (while bl (set-buffer (car (prog1 
> bl (setq bl (cdr bl))))) (if (org-mode-p) (setq bl nil))) (if (org-mode-p) 
> (progn (easy-menu-change (quote ("Org")) "File List for Agenda" (append (list 
> ["Edit File List" ... t] ["Add/Move Current File to Front of List" 
> org-agenda-file-to-front t] ["Remove Current File from List" org-remove-file 
> t] ["Cycle through agenda files" org-cycle-agenda-files t] ["Occur in all 
> agenda files" org-occur-in-agenda-files t] "--") (mapcar (quote 
> org-file-menu-entry) (org-agenda-files t))))))))
>   org-install-agenda-files-menu()

Do you have some old org.el on your system?  The current version
doesn't have a call to org-mode-p inside
org-install-agenda-files-menu, it does this:

  (defun org-install-agenda-files-menu ()
    (let ((bl (buffer-list)))
      (save-excursion
        (while bl
          (set-buffer (pop bl))
          (if (derived-mode-p 'org-mode) (setq bl nil)))
        (when (derived-mode-p 'org-mode)
          (easy-menu-change
           '("Org") "File List for Agenda"
           (append
            (list
             ["Edit File List" (org-edit-agenda-file-list) t]

As you see, it uses (derived-mode-p 'org-mode), not (org-mode-p).