[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#5928: grep.el: Incorrect processing of host-default settings in grep
|
From: |
Chong Yidong |
|
Subject: |
bug#5928: grep.el: Incorrect processing of host-default settings in grep-compute-defaults |
|
Date: |
Wed, 14 Apr 2010 11:34:42 -0400 |
> grep.el, bzr revision 99871, line 515:
>
> (set setting
> (or (cadr (assq setting host-defaults))
> (cadr (assq setting defaults)))))
>
> Value of host-defaults can be nil, e.g. for grep-use-null-device. In
> this case, cadr returns nil and the other branch of the or is
> executed, assigning the value from defaults to the setting and
> effectively discarding the value from host-defaults.
>
> The following patch fixes this issue:
Thanks. The patch looks clearly correct, and I've committed it.