[bug #60201] gettext-runtime/po/Makefile.in.in should not use @mkdir_p@

[Arfrever]

URL:
  <https://savannah.gnu.org/bugs/?60201>

                 Summary: gettext-runtime/po/Makefile.in.in should not use
@mkdir_p@
                 Project: GNU gettext
            Submitted by: arfrever
            Submitted on: Tue 09 Mar 2021 11:12:53 PM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

gettext provides /usr/share/gettext/po/Makefile.in.in (described as "Makefile
for PO directory in any package using GNU gettext.") which has this fragment
(https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=blob;f=gettext-runtime/po/Makefile.in.in;h=6b25f0d9167a5e1acdacdd54546e1a9911068f61;hb=HEAD#l35):


# We use $(mkdir_p).
# In automake <= 1.9.x, $(mkdir_p) is defined either as "mkdir -p --" or as
# "$(mkinstalldirs)" or as "$(install_sh) -d". For these automake versions,
# @install_sh@ does not start with $(SHELL), so we add it.
# In automake >= 1.10, @mkdir_p@ is derived from ${MKDIR_P}, which is defined
# either as "/path/to/mkdir -p" or ".../install-sh -c -d". For these automake
# versions, $(mkinstalldirs) and $(install_sh) are unused.
mkinstalldirs = $(SHELL) @install_sh@ -d
install_sh = $(SHELL) @install_sh@
MKDIR_P = @MKDIR_P@
mkdir_p = @mkdir_p@


With newer versions of Automake, @mkdir_p@ is no longer normally expanded.
@MKDIR_P@ is expanded, but MKDIR_P is actually not used anywhere else in this
file.

@mkdir_p@ would be expanded by deprecated AM_PROG_MKDIR_P macro:
https://git.savannah.gnu.org/gitweb/?p=automake.git;a=blob;f=m4/mkdirp.m4;h=0b6cc410db9dad03b2371d85c3027703ddca8058;hb=4a12201292d9f114549911cf5aaad15e1e5dce3c

My suggestion is to use $(MKDIR_P) instead of $(mkdir_p) in this file, and
drop above mkdir_p assignment.

Original report: https://bugs.gentoo.org/457986




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60201>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/