[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [PATCH 1/3] Add GtkBuilder UI files support

From: Miguel Ángel Arruga Vivas
Subject: Re: [bug-gettext] [PATCH 1/3] Add GtkBuilder UI files support
Date: Thu, 13 Jun 2013 19:08:32 +0200

Hi Daiki,

Daiki Ueno <address@hidden>: 
> Hi Miguel,
> Sorry for the long delay.  After more thinking, I realized that your
> original approach (splitting the parser for Glade 1, Glade 2, and
> GtkBuilder) would be better for the future maintenance, like this patch:
> https://github.com/644rosen/gettext_gtkbuilder_support/commit/19f6a2c6

Sorry for the mine one. I have been too busy these months and I have not
too much time.

> In do_glade2_start, you still need to manually check the element name
> for checking the description="..." attribute of the <atkaction>.  This
> looks like a refactoring failure :-)

Sorry for that. :-)

> Anyway, I've pushed a revised version and the test case.  Thanks very
> much for the patches.

You are welcome.

> Regards,
Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]