[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [PATCH 1/3] Add GtkBuilder UI files support

From: Daiki Ueno
Subject: Re: [bug-gettext] [PATCH 1/3] Add GtkBuilder UI files support
Date: Thu, 13 Jun 2013 17:47:31 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Hi Miguel,

Sorry for the long delay.  After more thinking, I realized that your
original approach (splitting the parser for Glade 1, Glade 2, and
GtkBuilder) would be better for the future maintenance, like this patch:


although I don't like some part, particularly kind of micro-refactoring
like this:

static void
init_glade2_tags ()
  /* When adding new keywords here, also update the documentation in
     xgettext.texi!  */
  static const char *tags_array[] = {
    "property", "atkproperty", "atkaction", NULL
  init_tags (tags_array);

In do_glade2_start, you still need to manually check the element name
for checking the description="..." attribute of the <atkaction>.  This
looks like a refactoring failure :-)

Anyway, I've pushed a revised version and the test case.  Thanks very
much for the patches.

Daiki Ueno

reply via email to

[Prev in Thread] Current Thread [Next in Thread]