[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [PATCH] Add a test wrapper to avoid temp file name col

From: Stefano Lattarini
Subject: Re: [bug-gettext] [PATCH] Add a test wrapper to avoid temp file name collision.
Date: Tue, 28 May 2013 12:47:56 +0200

On 05/28/2013 12:21 PM, Daiki Ueno wrote:
> Daiki Ueno <address@hidden> writes:
>> Hmm, that's unfortunate indeed.  Okay, let's remove the filename
>> conflicts either by adding a test script wrapper or sanitizing all the
>> tests.
> Here is a patch in the former approach (might be a bit hacky).
> Regards,
Tiny nit: there should be no need to add 'runtest.in' to EXTRA_DIST
if it is already declared in AC_CONFIG_FILES.  Automake should
distribute it automatically.

Other more important issues in runtest.in:

> (cd "tmp-$tst/tests" && "$srcdir/$tst" ${1+"$@"})
This will prevent the test to be run with the configure-detected shell.
That might be problematic on systems like Solaris I think, where /bin/sh
is *not* a POSIX shell.  Maybe something like this would be better (and
avoid an extra per-test fork+exec):

  (cd "tmp-$tst/tests" && . "$srcdir/$tst" ${1+"$@"})

> rm -fr $tmpfiles
This later 'rm' will cause the exit status of the just-run test to
be lost, no?  This way, all the tests will unconditionally pass...

Note that none of the above suggestions has been actually tested, so
caveat maintainer :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]